From 5c865b8dbb6f4405fdc9a850d5bda38cecdabf17 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=B6rn-Michael=20Miehe?= <jmm@yavook.de>
Date: Fri, 12 Dec 2025 16:50:19 +0000
Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7=20small=20UI=20fixes?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- update browserslist
- make BulmaBreadcrumbs clearer
- fix aspect ratio on SVGRect
- fix weird behaviour on DoorCanvas click
---
 ui/src/components/bulma/Breadcrumbs.vue |  2 +-
 ui/src/components/calendar/SVGRect.vue  | 16 +++++++---------
 ui/src/components/editor/DoorCanvas.vue | 20 ++++++++++----------
 ui/yarn.lock                            |  6 +++---
 4 files changed, 21 insertions(+), 23 deletions(-)

diff --git a/ui/src/components/bulma/Breadcrumbs.vue b/ui/src/components/bulma/Breadcrumbs.vue
index ad5c05d..659213d 100644
--- a/ui/src/components/bulma/Breadcrumbs.vue
+++ b/ui/src/components/bulma/Breadcrumbs.vue
@@ -8,7 +8,7 @@
         :class="model === index ? 'is-active' : ''"
         @click.left="model = index"
       >
-        <a>
+        <a :class="model === index ? 'has-text-primary' : ''">
           <span class="icon is-small">
             <FontAwesomeIcon :icon="step.icon" />
           </span>
diff --git a/ui/src/components/calendar/SVGRect.vue b/ui/src/components/calendar/SVGRect.vue
index 9e3fac9..a7878dc 100644
--- a/ui/src/components/calendar/SVGRect.vue
+++ b/ui/src/components/calendar/SVGRect.vue
@@ -1,10 +1,10 @@
 <template>
   <foreignObject
-    :x="Math.round(get_bg_aspect_ratio() * rectangle.left)"
+    :x="Math.round(aspect_ratio * rectangle.left)"
     :y="rectangle.top"
-    :width="Math.round(get_bg_aspect_ratio() * rectangle.width)"
+    :width="Math.round(aspect_ratio * rectangle.width)"
     :height="rectangle.height"
-    :style="`transform: scaleX(${1 / get_bg_aspect_ratio()})`"
+    :style="`transform: scaleX(${1 / aspect_ratio})`"
   >
     <div
       xmlns="http://www.w3.org/1999/xhtml"
@@ -23,6 +23,7 @@
 import { loading_success } from "@/lib/helpers";
 import { VueRectangle } from "@/lib/rects/rectangle";
 import { advent22Store } from "@/lib/store";
+import { computed } from "vue";
 
 const store = advent22Store();
 
@@ -45,14 +46,11 @@ withDefaults(
   },
 );
 
-function get_bg_aspect_ratio(): number {
+const aspect_ratio = computed(() => {
   if (!loading_success(store.background_image)) return 1;
 
-  return store.background_image.height / store.background_image.width;
-
-  // aspect_ratio is width/height!
-  // return store.background_image.aspect_ratio;
-}
+  return store.background_image.aspect_ratio;
+});
 </script>
 
 <style lang="scss" scoped>
diff --git a/ui/src/components/editor/DoorCanvas.vue b/ui/src/components/editor/DoorCanvas.vue
index 789bb78..2189e17 100644
--- a/ui/src/components/editor/DoorCanvas.vue
+++ b/ui/src/components/editor/DoorCanvas.vue
@@ -15,7 +15,7 @@
       force_visible
     />
     <SVGRect
-      v-if="preview_visible()"
+      v-if="preview_visible"
       variant="success"
       :rectangle="preview"
       visible
@@ -27,7 +27,7 @@
 import { Door } from "@/lib/rects/door";
 import { Rectangle } from "@/lib/rects/rectangle";
 import { Vector2D } from "@/lib/rects/vector2d";
-import { ref } from "vue";
+import { computed, ref } from "vue";
 
 import CalendarDoor from "../calendar/CalendarDoor.vue";
 import SVGRect from "../calendar/SVGRect.vue";
@@ -44,9 +44,7 @@ const MIN_RECT_AREA = 300;
 const state = ref<CanvasState>({ kind: "idle" });
 const preview = ref(new Rectangle());
 
-function preview_visible(): boolean {
-  return state.value.kind !== "idle";
-}
+const preview_visible = computed(() => state.value.kind !== "idle");
 
 function pop_door(point: Vector2D): Door | undefined {
   const idx = model.value.findIndex((rect) => rect.position.contains(point));
@@ -59,7 +57,7 @@ function pop_door(point: Vector2D): Door | undefined {
 }
 
 function draw_start(event: MouseEvent, point: Vector2D) {
-  if (preview_visible()) {
+  if (preview_visible.value) {
     return;
   }
 
@@ -68,17 +66,19 @@ function draw_start(event: MouseEvent, point: Vector2D) {
 }
 
 function draw_finish() {
-  if (state.value.kind !== "drawing" || preview.value.area < MIN_RECT_AREA) {
+  if (state.value.kind !== "drawing") {
     return;
   }
 
-  model.value.push(new Door(preview.value as Rectangle));
+  if (preview.value.area >= MIN_RECT_AREA) {
+    model.value.push(new Door(preview.value as Rectangle));
+  }
 
   state.value = { kind: "idle" };
 }
 
 function drag_start(event: MouseEvent, point: Vector2D) {
-  if (preview_visible()) {
+  if (preview_visible.value) {
     return;
   }
 
@@ -113,7 +113,7 @@ function on_mousemove(event: MouseEvent, point: Vector2D) {
 }
 
 function remove_rect(event: MouseEvent, point: Vector2D) {
-  if (preview_visible()) {
+  if (preview_visible.value) {
     return;
   }
 
diff --git a/ui/yarn.lock b/ui/yarn.lock
index c7cd6a4..15e056e 100644
--- a/ui/yarn.lock
+++ b/ui/yarn.lock
@@ -2602,9 +2602,9 @@ caniuse-api@^3.0.0:
     lodash.uniq "^4.5.0"
 
 caniuse-lite@^1.0.0, caniuse-lite@^1.0.30001538, caniuse-lite@^1.0.30001541:
-  version "1.0.30001651"
-  resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001651.tgz"
-  integrity sha512-9Cf+Xv1jJNe1xPZLGuUXLNkE1BoDkqRqYyFJ9TDYSqhduqA4hu4oR9HluGoWYQC/aj8WHjsGVV+bwkh0+tegRg==
+  version "1.0.30001760"
+  resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001760.tgz"
+  integrity sha512-7AAMPcueWELt1p3mi13HR/LHH0TJLT11cnwDJEs3xA4+CK/PLKeO9Kl1oru24htkyUKtkGCvAx4ohB0Ttry8Dw==
 
 case-sensitive-paths-webpack-plugin@^2.3.0:
   version "2.4.0"