From b1c65f4d4a86409dfbee9cbfa162c411c81c4406 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=B6rn-Michael=20Miehe?= <jmm@yavook.de>
Date: Sat, 21 Feb 2026 23:48:18 +0000
Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=A7=20ui:=20re-scaffolding?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- fix lint errors
---
 ui/_legacy/tsconfig.json                      | 21 ----------
 ui/src/__tests__/App.spec.ts                  | 11 -----
 ui/src/components/admin/CalendarAssistant.vue | 40 ++++++++++++-------
 ui/src/components/admin/ConfigView.vue        |  2 +-
 ui/src/components/editor/DoorChooser.vue      | 16 +++++++-
 ui/src/lib/api.ts                             |  7 +---
 ui/src/lib/helpers.ts                         |  1 -
 ui/src/lib/model.ts                           |  4 --
 ui/src/lib/store.ts                           |  2 +-
 ui/tsconfig.app.json                          |  2 +
 ui/tsconfig.vitest.json                       |  1 -
 ui/vite.config.ts                             |  5 ++-
 12 files changed, 49 insertions(+), 63 deletions(-)
 delete mode 100644 ui/_legacy/tsconfig.json
 delete mode 100644 ui/src/__tests__/App.spec.ts

diff --git a/ui/_legacy/tsconfig.json b/ui/_legacy/tsconfig.json
deleted file mode 100644
index 1a887f3..0000000
--- a/ui/_legacy/tsconfig.json
+++ /dev/null
@@ -1,21 +0,0 @@
-{
-  "extends": "@vue/tsconfig/tsconfig.dom.json",
-  "compilerOptions": {
-    "experimentalDecorators": true,
-    "lib": ["es2020", "dom", "dom.iterable", "es2022.object", "es2023.array"],
-    // "moduleResolution": "node",
-    // "sourceMap": true,
-    "baseUrl": ".",
-    "types": ["webpack-env", "mocha", "chai"],
-    "paths": {
-      "@/*": ["src/*"]
-    }
-  },
-  "include": [
-    "src/**/*.vue",
-    "src/**/*.ts",
-    // "src/**/*.tsx",
-    "tests/**/*.ts"
-    // "tests/**/*.tsx",
-  ]
-}
diff --git a/ui/src/__tests__/App.spec.ts b/ui/src/__tests__/App.spec.ts
deleted file mode 100644
index cf17422..0000000
--- a/ui/src/__tests__/App.spec.ts
+++ /dev/null
@@ -1,11 +0,0 @@
-import { describe, it, expect } from "vitest";
-
-import { mount } from "@vue/test-utils";
-import App from "../App.vue";
-
-describe("App", () => {
-  it("mounts renders properly", () => {
-    const wrapper = mount(App);
-    expect(wrapper.text()).toContain("You did it!");
-  });
-});
diff --git a/ui/src/components/admin/CalendarAssistant.vue b/ui/src/components/admin/CalendarAssistant.vue
index 3de966c..ef16cec 100644
--- a/ui/src/components/admin/CalendarAssistant.vue
+++ b/ui/src/components/admin/CalendarAssistant.vue
@@ -8,7 +8,7 @@
 
         <h3>Zuordnung Buchstaben</h3>
         <div class="tags are-medium">
-          <template v-for="(data, day) in day_data" :key="`part-${day}`">
+          <template v-for="[day, data] in day_data" :key="`part-${day}`">
             <span v-if="data.part === ''" class="tag is-warning">
               {{ day }}
             </span>
@@ -21,7 +21,7 @@
         <h3>Zuordnung Bilder</h3>
         <div class="tags are-medium">
           <span
-            v-for="(data, day) in day_data"
+            v-for="[day, data] in day_data"
             :key="`image-${day}`"
             :class="'tag is-' + (data.part === '' ? 'warning' : 'primary')"
           >
@@ -32,7 +32,7 @@
         <h3>Alle Türchen</h3>
         <div class="tags are-medium">
           <BulmaButton
-            v-for="(data, day) in day_data"
+            v-for="[day, data] in day_data"
             :key="`btn-${day}`"
             :class="'tag is-' + (data.part === '' ? 'warning' : 'info')"
             :icon="['fas', 'fa-door-open']"
@@ -48,14 +48,19 @@
 <script setup lang="ts">
 import { API } from "@/lib/api";
 import { name_door, objForEach } from "@/lib/helpers";
-import type { ImageData, NumStrDict } from "@/lib/model";
+import type { ImageData } from "@/lib/model";
 import { ref } from "vue";
 
 import MultiModal, { type HMultiModal } from "../MultiModal.vue";
 import BulmaButton from "../bulma/Button.vue";
 import BulmaDrawer from "../bulma/Drawer.vue";
 
-const day_data = ref<Record<number, { part: string; image_name: string }>>({});
+interface DayData {
+  part: string;
+  image_name: string;
+}
+
+const day_data = ref<Map<number, DayData>>(new Map());
 
 let modal: HMultiModal | undefined;
 
@@ -65,24 +70,31 @@ function on_modal_handle(handle: HMultiModal): void {
 
 async function on_open(): Promise<void> {
   const [day_parts, day_image_names] = await Promise.all([
-    API.request<NumStrDict>("admin/day_parts"),
-    API.request<NumStrDict>("admin/day_image_names"),
+    API.request<Record<number, string>>("admin/day_parts"),
+    API.request<Record<number, string>>("admin/day_image_names"),
   ]);
 
-  const _ensure_day_in_data = (day: number) => {
-    if (!(day in day_data.value)) {
-      day_data.value[day] = { part: "", image_name: "" };
+  const _get_data = (day: number) => {
+    let result = day_data.value.get(day);
+
+    if (result === undefined) {
+      result = { part: "", image_name: "" };
+      day_data.value.set(day, result);
     }
+
+    return result;
   };
 
+  // for (const [day, part] of day_parts.entries()) {
+  //   _get_data(day).part = part;
+  // }
+
   objForEach(day_parts, (day, part) => {
-    _ensure_day_in_data(day);
-    day_data.value[day].part = part;
+    _get_data(day).part = part;
   });
 
   objForEach(day_image_names, (day, image_name) => {
-    _ensure_day_in_data(day);
-    day_data.value[day].image_name = image_name;
+    _get_data(day).image_name = image_name;
   });
 }
 
diff --git a/ui/src/components/admin/ConfigView.vue b/ui/src/components/admin/ConfigView.vue
index a7afd69..139095e 100644
--- a/ui/src/components/admin/ConfigView.vue
+++ b/ui/src/components/admin/ConfigView.vue
@@ -232,7 +232,7 @@ const admin_config_model = ref<AdminConfigModel>({
 });
 
 const doors = ref<DoorSaved[]>([]);
-const creds = ref<Record<string, Credentials>>({
+const creds = ref({
   dav: {
     username: "",
     password: "",
diff --git a/ui/src/components/editor/DoorChooser.vue b/ui/src/components/editor/DoorChooser.vue
index aa2e196..8c237f5 100644
--- a/ui/src/components/editor/DoorChooser.vue
+++ b/ui/src/components/editor/DoorChooser.vue
@@ -13,14 +13,19 @@
     <figure class="image is-unselectable">
       <img :src="unwrap_loading(store.background_image).data_url" />
       <ThouCanvas>
-        <PreviewDoor v-for="(_, index) in model" :key="`door-${index}`" v-model="model[index]" />
+        <PreviewDoor
+          v-for="(door, index) in model"
+          :key="`door-${index}`"
+          :model-value="door"
+          @update:model-value="updateAt(index, door)"
+        />
       </ThouCanvas>
     </figure>
   </div>
 </template>
 
 <script setup lang="ts">
-import { type VueLike, unwrap_loading } from "@/lib/helpers";
+import { unwrap_loading, type VueLike } from "@/lib/helpers";
 import { Door } from "@/lib/rects/door";
 import { advent22Store } from "@/lib/store";
 
@@ -28,5 +33,12 @@ import ThouCanvas from "../calendar/ThouCanvas.vue";
 import PreviewDoor from "./PreviewDoor.vue";
 
 const model = defineModel<VueLike<Door>[]>({ required: true });
+
+function updateAt(i: number, val: VueLike<Door>) {
+  const copy = [...model.value];
+  copy[i] = val;
+  model.value = copy;
+}
+
 const store = advent22Store();
 </script>
diff --git a/ui/src/lib/api.ts b/ui/src/lib/api.ts
index 01fbbdd..2621f2c 100644
--- a/ui/src/lib/api.ts
+++ b/ui/src/lib/api.ts
@@ -18,12 +18,8 @@ interface Params {
 export class API {
   private static get api_baseurl(): string {
     // in production mode, return "proto://hostname/api"
-    if (process.env.NODE_ENV === "production") {
+    if (import.meta.env.PROD) {
       return `${window.location.protocol}//${window.location.host}/api`;
-    } else if (process.env.NODE_ENV !== "development") {
-      // not in prouction or development mode
-      // eslint-disable-next-line no-console
-      console.warn("Unexpected NODE_ENV value: ", process.env.NODE_ENV);
     }
 
     // in development mode, return "proto://hostname:8000/api"
@@ -84,7 +80,6 @@ export class API {
       const response = await this.axios.request<T>(this.get_axios_config(p));
       return response.data;
     } catch (reason) {
-      // eslint-disable-next-line no-console
       console.error(`Failed to query ${p.endpoint}: ${reason}`);
       throw new APIError(reason, p.endpoint);
     }
diff --git a/ui/src/lib/helpers.ts b/ui/src/lib/helpers.ts
index 43144c5..985e5fd 100644
--- a/ui/src/lib/helpers.ts
+++ b/ui/src/lib/helpers.ts
@@ -39,7 +39,6 @@ export function handle_error(error: unknown): void {
   if (error instanceof APIError) {
     error.alert();
   } else {
-    // eslint-disable-next-line no-console
     console.error(error);
   }
 }
diff --git a/ui/src/lib/model.ts b/ui/src/lib/model.ts
index 44b684e..f2e021a 100644
--- a/ui/src/lib/model.ts
+++ b/ui/src/lib/model.ts
@@ -45,10 +45,6 @@ export interface SiteConfigModel {
   footer: string;
 }
 
-export interface NumStrDict {
-  [key: number]: string;
-}
-
 export interface DoorSaved {
   day: number;
   x1: number;
diff --git a/ui/src/lib/store.ts b/ui/src/lib/store.ts
index cee8073..bbbdba0 100644
--- a/ui/src/lib/store.ts
+++ b/ui/src/lib/store.ts
@@ -62,7 +62,7 @@ export const advent22Store = defineStore("advent22", {
 
         if (link.parentElement === null)
           document.getElementsByTagName("head")[0]!.appendChild(link);
-      } catch {}
+      } catch { }
 
       try {
         const [is_admin, site_config, background_image, user_doors, next_door] = await Promise.all([
diff --git a/ui/tsconfig.app.json b/ui/tsconfig.app.json
index 913b8f2..5f4dd8a 100644
--- a/ui/tsconfig.app.json
+++ b/ui/tsconfig.app.json
@@ -5,6 +5,8 @@
   "compilerOptions": {
     "tsBuildInfoFile": "./node_modules/.tmp/tsconfig.app.tsbuildinfo",
 
+    "lib": ["es2020", "dom", "dom.iterable", "es2022.object", "es2023.array"],
+
     "paths": {
       "@/*": ["./src/*"]
     }
diff --git a/ui/tsconfig.vitest.json b/ui/tsconfig.vitest.json
index 7d1d8ce..40b43da 100644
--- a/ui/tsconfig.vitest.json
+++ b/ui/tsconfig.vitest.json
@@ -5,7 +5,6 @@
   "compilerOptions": {
     "tsBuildInfoFile": "./node_modules/.tmp/tsconfig.vitest.tsbuildinfo",
 
-    "lib": [],
     "types": ["node", "jsdom"]
   }
 }
diff --git a/ui/vite.config.ts b/ui/vite.config.ts
index 7483182..2760636 100644
--- a/ui/vite.config.ts
+++ b/ui/vite.config.ts
@@ -1,7 +1,7 @@
 import { fileURLToPath, URL } from "node:url";
 
-import { defineConfig } from "vite";
 import vue from "@vitejs/plugin-vue";
+import { defineConfig } from "vite";
 import vueDevTools from "vite-plugin-vue-devtools";
 
 // https://vite.dev/config/
@@ -12,4 +12,7 @@ export default defineConfig({
       "@": fileURLToPath(new URL("./src", import.meta.url)),
     },
   },
+  build: {
+    sourcemap: true,
+  },
 });