diff --git a/src/file/checked.rs b/src/file/checked.rs index 2395234..2af7f73 100644 --- a/src/file/checked.rs +++ b/src/file/checked.rs @@ -118,17 +118,17 @@ mod tests { use crate::{ sharry::{Client, json::NewShareRequest}, -test_util::{ - MockClient, check_trait, create_file, - data::{HASHES_STD_GOOD, cases, data}, -}, + test_util::{ + MockClient, check_trait, create_file, + data::{HASHES_STD_GOOD, cases, data}, + }, }; use super::*; fn create_checked(content: &[u8]) -> (Checked, NamedTempFile) { let file = create_file(content); - let chk = Checked::new(file.path()).expect("creating `Checked` should succeed"); + let chk = Checked::new(file.path()).unwrap(); // return both, so the `NamedTempFile` is not auto-deleted here (chk, file) @@ -138,21 +138,14 @@ test_util::{ fn new_on_existing_file_works() { for (content, size) in cases() { let (chk, file) = create_checked(content); - - let path = file - .path() - .canonicalize() - .expect("the file should have a canonical path"); + let path = file.path().canonicalize().unwrap(); assert_eq!(chk.path, path); assert_eq!(chk.size, size); assert!(chk.hash.is_none()); // `FileTrait` - assert_eq!( - chk.get_name(), - file.path().file_name().expect("`file_name` should succeed") - ); + assert_eq!(chk.get_name(), file.path().file_name().unwrap()); assert_eq!(chk.get_size(), size); check_trait( @@ -162,7 +155,7 @@ test_util::{ "Checked", ); - // new unchecked + // new_unchecked let chk = unsafe { Checked::new_unchecked(chk.path, chk.size, chk.hash) }; assert_eq!(chk.path, path); assert_eq!(chk.size, size); @@ -172,13 +165,13 @@ test_util::{ #[test] fn new_on_dir_errors() { - let tempdir = TempDir::new().expect("creating temp dir"); + let tempdir = TempDir::new().unwrap(); let fs_root = PathBuf::from("/"); let dirs = [tempdir.path(), fs_root.as_path()]; for p in dirs { - let err = Checked::new(p).expect_err("creating `Checked` should fail"); + let err = Checked::new(p).unwrap_err(); assert_eq!(err.kind(), io::ErrorKind::InvalidInput); #[cfg(target_os = "linux")] assert_eq!(err.to_string(), "Not a regular file"); @@ -187,11 +180,11 @@ test_util::{ #[test] fn new_on_nex_errors() { - let tempdir = TempDir::new().expect("creating temp dir"); + let tempdir = TempDir::new().unwrap(); let nex_paths = [0, 1, 2, 3, 4].map(|i| tempdir.path().join(format!("nex_{i}.ext"))); for p in nex_paths { - let err = Checked::new(p).expect_err("creating `Checked` should fail"); + let err = Checked::new(p).unwrap_err(); assert_eq!(err.kind(), io::ErrorKind::NotFound); #[cfg(target_os = "linux")] assert_eq!(err.to_string(), "No such file or directory (os error 2)"); @@ -203,9 +196,9 @@ test_util::{ for (content, hash) in data().zip(HASHES_STD_GOOD) { let (mut chk, _file) = create_checked(content); - chk.hash(drop).expect("`hash` should succeed"); + chk.hash(drop).unwrap(); // `FileTrait` - chk.check_hash(drop).expect("`check_hash` should succeed"); + chk.check_hash(drop).unwrap(); assert_eq!(chk.hash, Some(hash.to_string())); } @@ -218,7 +211,7 @@ test_util::{ // fake hash chk.hash = Some(String::default()); - let err = chk.hash(drop).expect_err("`hash` twice should fail"); + let err = chk.hash(drop).unwrap_err(); assert!(err.is_mismatch("unhashed file", chk.path.display().to_string())); } @@ -227,19 +220,19 @@ test_util::{ #[test] fn start_upload_works() { let client = MockClient::default(); -let uri = sharry::Uri::from(true); + let uri = sharry::Uri::from(true); let alias_id = sharry::AliasID::from(true); let share_id = client .share_create(&uri, &alias_id, NewShareRequest::new("share", 0)) - .expect(""); + .unwrap(); for content in data() { let (chk, _file) = create_checked(content); assert!( - chk.start_upload( &client, &uri, &alias_id, &share_id ) - .is_ok() + chk.start_upload(&client, &uri, &alias_id, &share_id) + .is_ok() ); } } diff --git a/src/file/mod.rs b/src/file/mod.rs index 8420d48..3910991 100644 --- a/src/file/mod.rs +++ b/src/file/mod.rs @@ -139,8 +139,7 @@ mod tests { // to capture progress updates from `compute_hash` let mut read_total = 0; let callback = |n| read_total += n; - - let hash = compute_hash(file.path(), size, callback).expect("hash should succeed"); + let hash = compute_hash(file.path(), size, callback).unwrap(); assert_eq!(hash, expected_hash); assert_eq!(read_total, size); @@ -151,21 +150,16 @@ mod tests { fn hash_size_mismatch() { for (content, good_size, bad_size) in cases_with(DATA_LENGTHS_BAD) { let file = create_file(content); - let callback = drop; { - let err = compute_hash(file.path(), bad_size, callback) - .expect_err("compute_hash should report a mismatch"); - - // check error + // `compute_hash` with bad size + let err = compute_hash(file.path(), bad_size, drop).unwrap_err(); assert!(err.is_mismatch(bad_size.to_string(), good_size.to_string())); } { - let err = check_hash(file.path(), bad_size, Some("foobar"), callback) - .expect_err("check_hash should report a mismatch"); - - // check error + // `check_hash` with bad size + let err = check_hash(file.path(), bad_size, Some("foobar"), drop).unwrap_err(); assert!(err.is_mismatch(bad_size.to_string(), good_size.to_string())); } } @@ -175,12 +169,9 @@ mod tests { fn hash_value_none() { for (content, size) in cases() { let file = create_file(content); - let callback = drop; - let err = check_hash(file.path(), size, None, callback) - .expect_err("check_hash should report a mismatch"); - - // check error + // `check_hash` with no hash + let err = check_hash(file.path(), size, None, drop).unwrap_err(); assert!(err.is_mismatch("hash", file.path().display().to_string())); } } @@ -191,12 +182,9 @@ mod tests { cases_with(HASHES_STD_GOOD).zip(HASHES_STD_BAD) { let file = create_file(content); - let callback = drop; - let err = check_hash(file.path(), size, Some(bad_hash), callback) - .expect_err("check_hash should report a mismatch"); - - // check error + // `check_hash` with bad hash + let err = check_hash(file.path(), size, Some(bad_hash), drop).unwrap_err(); assert!(err.is_mismatch(bad_hash, good_hash)); } } diff --git a/src/sharry/ids.rs b/src/sharry/ids.rs index 62e054f..d30bcff 100644 --- a/src/sharry/ids.rs +++ b/src/sharry/ids.rs @@ -171,12 +171,8 @@ mod tests { ]; for (good, expected_fid) in cases { - let file_id = - FileID::try_from(good.to_string()).expect("URL should parse successfully"); - assert_eq!( - file_id.0, expected_fid, - "Expected `{good}` → FileID({expected_fid}), got {file_id:?}", - ); + let file_id = FileID::try_from(good.to_string()).unwrap(); + assert_eq!(file_id.0, expected_fid); } } @@ -196,7 +192,7 @@ mod tests { ]; for bad in bad_inputs { - let err = FileID::try_from(bad.to_string()).expect_err("URL should not parse"); + let err = FileID::try_from(bad.to_string()).unwrap_err(); // make sure it's the Mismatch variant, and that it contains the original input assert!(err.is_mismatch( ":///api/v2/alias/upload//files/tus/", diff --git a/src/test_util/mock_client.rs b/src/test_util/mock_client.rs index 2548dee..e31a8cd 100644 --- a/src/test_util/mock_client.rs +++ b/src/test_util/mock_client.rs @@ -71,7 +71,7 @@ impl MockClient { .ok_or_else(|| error_response!("can't find share {share_id:?}!"))?; Ok(RefMut::map(shares, |shares| { - shares.get_mut(share_id).expect("checked but None!") + shares.get_mut(share_id).unwrap() })) } @@ -90,7 +90,7 @@ impl MockClient { .ok_or_else(|| error_response!("can't find file {file_id:?}!"))?; Ok(RefMut::map(share, move |share| { - share.files.get_mut(file_id).expect("checked but None!") + share.files.get_mut(file_id).unwrap() })) } } diff --git a/src/test_util/mock_ids.rs b/src/test_util/mock_ids.rs index 19bcfa0..0a1e07f 100644 --- a/src/test_util/mock_ids.rs +++ b/src/test_util/mock_ids.rs @@ -142,8 +142,8 @@ mod tests { #[test] fn false_makes_invalids() { fn test_check(value: impl CheckID, callback: impl FnOnce(&Parameter) -> bool) { - let check = value.check().expect_err("should be invalid"); - let p = check.get_invalid_param().expect("should be InvalidParam"); + let check = value.check().unwrap_err(); + let p = check.get_invalid_param().unwrap(); assert!(callback(p)); } diff --git a/src/test_util/mod.rs b/src/test_util/mod.rs index be4b48a..abba60f 100644 --- a/src/test_util/mod.rs +++ b/src/test_util/mod.rs @@ -24,7 +24,7 @@ where /// Helper to create a temp file from `data` pub fn create_file(data: &[u8]) -> NamedTempFile { - let mut tmp = NamedTempFile::new().expect("creating temp file"); - tmp.write_all(data).expect("writing to tempfile"); + let mut tmp = NamedTempFile::new().unwrap(); + tmp.write_all(data).unwrap(); tmp }