notes

- remove `AppState::file_names`, `CacheFile::file_names`, `FileState::file_name`
- add `Cli::file_names`
- clippy fix

notes.md

@@ -53,3 +53,4 @@
 - hashing
     - store file hashes with all `file::*` variants
     - check hashes on "continue"
+    - CLI switch to skip hashing

src/appstate.rs

@@ -136,7 +136,7 @@ impl AppState {
             }
             Err(path) => {
                 debug!("Finished {:?}!", path.display());
-                self.end_progressbar(|pb| pb.finish());
+                self.end_progressbar(ProgressBar::finish);
             }
         }
 
@@ -174,15 +174,11 @@ impl AppState {
         let checked = uploading.abort();
         self.inner.requeue_file(checked);
 
-        self.end_progressbar(|pb| pb.abandon());
+        self.end_progressbar(ProgressBar::abandon);
 
         Some(self)
     }
 
-    pub fn file_names(&self) -> Vec<&str> {
-        self.inner.file_names()
-    }
-
     pub fn save(&self) -> io::Result<()> {
         self.inner.save()
     }

src/cachefile.rs

@@ -10,7 +10,7 @@ use serde::{Deserialize, Serialize};
 
 use crate::{
     cli::Cli,
-    file::{self, Chunk, FileTrait},
+    file::{self, Chunk},
     sharry::{self, Client, Uri},
 };
 
@@ -21,13 +21,6 @@ enum FileState {
 }
 
 impl FileState {
-    fn file_name(&self) -> &str {
-        match self {
-            FileState::C(c) => c.get_name(),
-            FileState::U(u) => u.get_name(),
-        }
-    }
-
     fn start_upload(
         self,
         client: &impl sharry::Client,
@@ -92,10 +85,6 @@ impl CacheFile {
         }
     }
 
-    pub fn file_names(&self) -> Vec<&str> {
-        self.files.iter().map(FileState::file_name).collect()
-    }
-
     pub fn is_empty(&self) -> bool {
         self.files.is_empty()
     }

src/cli.rs

@@ -14,7 +14,7 @@ use clap::{
 use log::LevelFilter;
 
 use crate::{
-    file::Checked,
+    file::{Checked, FileTrait},
     sharry::{NewShareRequest, Uri},
 };
 
@@ -130,6 +130,10 @@ impl Cli {
         }
     }
 
+    pub fn file_names(&self) -> Vec<&str> {
+        self.files.iter().map(FileTrait::get_name).collect()
+    }
+
     pub fn get_hash(&self) -> String {
         let file_refs = {
             let mut refs: Vec<_> = self.files.iter().collect();

src/main.rs

@@ -73,7 +73,7 @@ fn main() {
 
     info!("continuing with state: {state:#?}");
 
-    let fns_magenta = output::style_all(&state.file_names(), |s| style(s).magenta()).join(", ");
+    let fns_magenta = output::style_all(&args.file_names(), |s| style(s).magenta()).join(", ");
 
     println!("{} is uploading: {fns_magenta}", *SHRUPL);
 
@@ -90,8 +90,7 @@ fn main() {
                 Log::handle(&e);
                 tries += 1;
 
-                match e {
-                    ClientError::InvalidParameter(p) => match p {
+                if let ClientError::InvalidParameter(p) = e { match p {
                     // TODO Error 404: File not found
                     Parameter::FileID(fid) => {
                         // requeue file
@@ -107,8 +106,7 @@ fn main() {
                         Log::error(format_args!("404 sid: {sid}"));
                     }
                     p => Log::error(format_args!("Unexpected {p}!")),
-                    },
-                    _ => {
+                } } else {
                     // retry chunk
                     let Some(s) = state.rewind() else {
                         Log::error("Failed to retry chunk!");
@@ -118,7 +116,6 @@ fn main() {
                     state = s;
                 }
             }
-            }
             Ok(false) => {
                 trace!("chunk uploaded");
                 tries = 0;