[wip] unit tests for file module

- testing for `Uploading`

src/error.rs

@@ -40,7 +40,27 @@ impl_param_from! {
 
 impl Parameter {
     fn is_fatal(&self) -> bool {
-        matches!(self, Self::Uri(_) | Self::AliasID(_))
+        self.is_uri() || self.is_alias_id()
+    }
+
+    #[must_use]
+    pub fn is_uri(&self) -> bool {
+        matches!(self, Self::Uri(_))
+    }
+
+    #[must_use]
+    pub fn is_alias_id(&self) -> bool {
+        matches!(self, Self::AliasID(_))
+    }
+
+    #[must_use]
+    pub fn is_share_id(&self) -> bool {
+        matches!(self, Self::ShareID(_))
+    }
+
+    #[must_use]
+    pub fn is_file_id(&self) -> bool {
+        matches!(self, Self::FileID(_))
     }
 }
 
@@ -123,17 +143,34 @@ impl Error {
         })
     }
 
+    #[must_use]
+    pub fn is_stdio_kind(&self, kind: std::io::ErrorKind) -> bool {
+        if let Self::StdIo(e) = self {
+            e.kind() == kind
+        } else {
+            false
+        }
+    }
+
     pub fn is_mismatch<E, A>(&self, want_expected: E, want_actual: A) -> bool
     where
         E: AsRef<str>,
         A: AsRef<str>,
     {
-        matches!(
-            self,
-            Self::Mismatch { expected, actual }
-                if expected == want_expected.as_ref()
-                && actual == want_actual.as_ref()
-        )
+        if let Self::Mismatch { expected, actual } = self {
+            expected == want_expected.as_ref() && actual == want_actual.as_ref()
+        } else {
+            false
+        }
+    }
+
+    #[must_use]
+    pub fn response_contains(&self, pat: &str) -> bool {
+        if let Self::Response(r) = self {
+            r.contains(pat)
+        } else {
+            false
+        }
     }
 
     #[must_use]

src/file/mod.rs

@@ -158,7 +158,7 @@ mod tests {
         };
 
         let err = compute_hash(&nex_path, 0, drop).unwrap_err();
-        assert!(matches!(err, crate::Error::StdIo(e) if e.kind() == std::io::ErrorKind::NotFound));
+        assert!(err.is_stdio_kind(std::io::ErrorKind::NotFound));
     }
 
     #[test]
@@ -166,9 +166,7 @@ mod tests {
         let dir = TempDir::new().unwrap();
 
         let err = compute_hash(dir.path(), 0, drop).unwrap_err();
-        assert!(
-            matches!(err, crate::Error::StdIo(e) if e.kind() == std::io::ErrorKind::IsADirectory)
-        );
+        assert!(err.is_stdio_kind(std::io::ErrorKind::IsADirectory));
     }
 
     #[test]

src/file/uploading.rs

@@ -145,7 +145,7 @@ mod tests {
         sharry::{Client, json::NewShareRequest},
         test_util::{
             MockClient, create_file,
-            data::{DATA_LENGTHS_BAD, cases, cases_with},
+            data::{DATA_LENGTHS_BAD, cases, cases_with, data},
         },
     };
 
@@ -248,13 +248,13 @@ mod tests {
 
     #[test]
     fn check_rewind_works() {
-        let cases = cases()
+        let data = cases()
             // ignore "empty" testcase
             .filter(|&(_, size)| size > 0)
             // remove "size"
             .map(|(content, _)| content);
 
-        for content in cases {
+        for content in data {
             let (mut upl, _share_id, _file) = create_uploading(content);
 
             // read 1 byte and rewind
@@ -269,4 +269,72 @@ mod tests {
             assert!(upl.rewind().is_none());
         }
     }
+
+    #[test]
+    fn upload_works() {
+        let client = MockClient::default();
+        let uri = sharry::Uri::from(true);
+        let alias_id = sharry::AliasID::from(true);
+
+        let share_id = client
+            .share_create(&uri, &alias_id, NewShareRequest::new("share", 0))
+            .unwrap();
+
+        let mut buf = vec![0; 1024 * 1024];
+
+        for content in data() {
+            let file = create_file(content);
+            let mut upl = Checked::new(file.path())
+                .unwrap()
+                .start_upload(&client, &uri, &alias_id, &share_id)
+                .unwrap();
+
+            while let Ok(chunk) = upl.read(&mut buf) {
+                assert!(
+                    client
+                        .file_patch(&uri, &alias_id, &share_id, &chunk)
+                        .is_ok()
+                );
+            }
+
+            assert_eq!(upl.offset, upl.size);
+        }
+    }
+
+    #[test]
+    fn check_upload_bad_align() {
+        let data = cases()
+            // ignore "empty" testcase
+            .filter(|&(_, size)| size >= 2)
+            // remove "size"
+            .map(|(content, _)| content);
+
+        let client = MockClient::default();
+        let uri = sharry::Uri::from(true);
+        let alias_id = sharry::AliasID::from(true);
+
+        let share_id = client
+            .share_create(&uri, &alias_id, NewShareRequest::new("share", 0))
+            .unwrap();
+
+        // single-byte buffer to force bad chunk alignment
+        let mut buf = [0];
+        for content in data {
+            let file = create_file(content);
+            let mut upl = Checked::new(file.path())
+                .unwrap()
+                .start_upload(&client, &uri, &alias_id, &share_id)
+                .unwrap();
+
+            // first chunk works
+            client
+                .file_patch(&uri, &alias_id, &share_id, &upl.read(&mut buf).unwrap())
+                .unwrap();
+
+            // second chunk misaligned
+            let res = client.file_patch(&uri, &alias_id, &share_id, &upl.read(&mut buf).unwrap());
+            assert!(res.is_err());
+            assert!(res.unwrap_err().response_contains("not aligned to a MiB"));
+        }
+    }
 }

src/test_util/mock_client.rs

@@ -222,11 +222,9 @@ mod tests {
         let share_ids: [_; 10] = std::array::from_fn(|_| add_share(&client));
 
         for share_id in share_ids.as_ref() {
-            let res = client.insert_share(&share_id, MockShare::default());
+            let res = client.insert_share(share_id, MockShare::default());
             assert!(res.is_err());
-            assert!(
-                matches!(res.unwrap_err(), Error::Response(s) if s.contains("can't insert share"))
-            );
+            assert!(res.unwrap_err().response_contains("can't insert share"));
         }
     }
 
@@ -250,9 +248,7 @@ mod tests {
             let res = client.get_share(share_id_nex);
 
             assert!(res.is_err());
-            assert!(
-                matches!(res.unwrap_err(), Error::Response(s) if s.contains("can't find share"))
-            );
+            assert!(res.unwrap_err().response_contains("can't find share"));
         }
     }
 
@@ -284,7 +280,7 @@ mod tests {
         let share_id_nex = ShareID::default();
         let res = client.insert_file(&share_id_nex, &FileID::from(true), MockFile::default());
         assert!(res.is_err());
-        assert!(matches!(res.unwrap_err(), Error::Response(s) if s.contains("can't find share")));
+        assert!(res.unwrap_err().response_contains("can't find share"));
     }
 
     #[test]
@@ -294,11 +290,9 @@ mod tests {
         let file_ids: [_; 10] = std::array::from_fn(|_| add_file(&client, &share_id));
 
         for file_id in file_ids.as_ref() {
-            let res = client.insert_file(&share_id, &file_id, MockFile::default());
+            let res = client.insert_file(&share_id, file_id, MockFile::default());
             assert!(res.is_err());
-            assert!(
-                matches!(res.unwrap_err(), Error::Response(s) if s.contains("can't insert file"))
-            );
+            assert!(res.unwrap_err().response_contains("can't insert file"));
         }
     }
 
@@ -325,16 +319,12 @@ mod tests {
             let res = client.get_file(&share_id_nex, file_id_nex);
 
             assert!(res.is_err());
-            assert!(
-                matches!(res.unwrap_err(), Error::Response(s) if s.contains("can't find share"))
-            );
+            assert!(res.unwrap_err().response_contains("can't find share"));
 
             let res = client.get_file(&share_id, file_id_nex);
 
             assert!(res.is_err());
-            assert!(
-                matches!(res.unwrap_err(), Error::Response(s) if s.contains("can't find file"))
-            );
+            assert!(res.unwrap_err().response_contains("can't find file"));
         }
     }
 }

src/test_util/mock_ids.rs

@@ -160,23 +160,17 @@ mod tests {
         let share_id_i = ShareID::from(false);
         let file_id_i = FileID::from(false);
 
-        // param checks
-        let is_uri_i = |p: &Parameter| matches!(p, Parameter::Uri(_));
-        let is_alias_id_i = |p: &Parameter| matches!(p, Parameter::AliasID(_));
-        let is_share_id_i = |p: &Parameter| matches!(p, Parameter::ShareID(_));
-        let is_file_id_i = |p: &Parameter| matches!(p, Parameter::FileID(_));
-
         // uri + alias
-        test_check((&uri_i, &alias_id_i), is_uri_i);
-        test_check((&uri_i, &alias_id), is_uri_i);
-        test_check((&uri, &alias_id_i), is_alias_id_i);
+        test_check((&uri_i, &alias_id_i), Parameter::is_uri);
+        test_check((&uri_i, &alias_id), Parameter::is_uri);
+        test_check((&uri, &alias_id_i), Parameter::is_alias_id);
 
         // share
-        test_check(&share_id_i, is_share_id_i);
+        test_check(&share_id_i, Parameter::is_share_id);
 
         // share + file
-        test_check((&share_id_i, &file_id_i), is_share_id_i);
-        test_check((&share_id_i, &file_id), is_share_id_i);
-        test_check((&share_id, &file_id_i), is_file_id_i);
+        test_check((&share_id_i, &file_id_i), Parameter::is_share_id);
+        test_check((&share_id_i, &file_id), Parameter::is_share_id);
+        test_check((&share_id, &file_id_i), Parameter::is_file_id);
     }
 }